-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge initial accurate sizes work into trunk #1329
Conversation
…curate-sizes-image-cover-block
…-cover-block Initial implementation of improved image `sizes` algorithm
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this open. Leaving a review to mark this as blocked until all of the planned work on this feature for v1 is completed.
Update `Auto-sizes for Lazy-loaded Images` plugin name to `Enhanced Responsive Images` Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org> Co-authored-by: westonruter <westonruter@git.wordpress.org> Co-authored-by: joemcgill <joemcgill@git.wordpress.org> Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org> Co-authored-by: thelovekesh <thelovekesh@git.wordpress.org>
Co-authored-by: Weston Ruter <westonruter@google.com>
Update the plugin description for Enhanced Responsive Images
@joemcgill @westonruter @swissspidy The PR is ready for review. The version bump and changelog is part of #1332. Can we merge this today, please? |
@joemcgill Is this PR still blocked from merging? @mukeshpanchal27 I've updated the issues and PRs related to this PR to ensure they are all milestoned for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good to merge into trunk and iterate from there.
The PR merge the initial set of work for accurate sizes to the trunk for release.
Initial feature release issues:
sizes
algorithm #1187sizes
values #1251sizes
for left/right/center alignment #1289