Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge initial accurate sizes work into trunk #1329

Merged
merged 53 commits into from
Jul 11, 2024

Conversation

Copy link

github-actions bot commented Jul 3, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: joemcgill <joemcgill@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this open. Leaving a review to mark this as blocked until all of the planned work on this feature for v1 is completed.

westonruter and others added 3 commits July 9, 2024 11:16
Update `Auto-sizes for Lazy-loaded Images` plugin name to `Enhanced Responsive Images`

Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: joemcgill <joemcgill@git.wordpress.org>
Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org>
Co-authored-by: thelovekesh <thelovekesh@git.wordpress.org>
joemcgill and others added 4 commits July 9, 2024 18:19
Co-authored-by: Weston Ruter <westonruter@google.com>
Update the plugin description for Enhanced Responsive Images
@mukeshpanchal27
Copy link
Member Author

@joemcgill @westonruter @swissspidy The PR is ready for review. The version bump and changelog is part of #1332. Can we merge this today, please?

@westonruter westonruter added skip changelog PRs that should not be mentioned in changelogs and removed no milestone PRs that do not have a defined milestone for release labels Jul 10, 2024
@westonruter
Copy link
Member

westonruter commented Jul 10, 2024

@joemcgill Is this PR still blocked from merging?

@mukeshpanchal27 I've updated the issues and PRs related to this PR to ensure they are all milestoned for auto-sizes 1.1.0 and have the appropriate labels.

Copy link
Member

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to merge into trunk and iterate from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Enhanced Responsive Images Issues for the Enhanced Responsive Images plugin skip changelog PRs that should not be mentioned in changelogs [Type] Enhancement A suggestion for improvement of an existing feature
4 participants