Only filter final output buffer in Optimization Detective #1317
+62
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
added
the
[Plugin] Optimization Detective
westonruter
commented
Jun 24, 2024
westonruter
force-pushed
the
update/ob-handling
branch
from
01f7be3
to
b3ce59e
Compare
westonruter
force-pushed
the
update/ob-handling
branch
from
cea1286
to
13e068d
Compare
westonruter
commented
Aug 2, 2024
westonruter
commented
Aug 2, 2024
Update test-optimization.php
westonruter
added
the
[Type] Enhancement
westonruter
changed the title
westonruter
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on @nextend's recommendation in WordPress/gutenberg#61212 (comment) feedback which is drafted in WordPress/gutenberg#62770. If a template calls
ob_clean()at present, the output buffer being thrown away will be sent into the output buffer callback for needless processing even though it won't be served. This PR fixes addresses this issue by making sure the output buffer phase isPHP_OUTPUT_HANDLER_FINAL.