Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release/3.0.0 additions into trunk to unblock #1113

Merged
merged 12 commits into from
Apr 5, 2024
Merged

Conversation

felixarntz
Copy link
Member

This is simply a merge of #1111 and #1112 from the 3.0.0 release branch into trunk.

Normally we would only do this after the 3.0.0 release, but because #1112 avoids CI failures in trunk and #1111 unblocks working on #1032, it makes sense to already merge these two changes back at this point.

@felixarntz felixarntz added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release labels Apr 4, 2024
Copy link

github-actions bot commented Apr 4, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: felixarntz <flixos90@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: joemcgill <joemcgill@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me, though we'll need to make sure that the version bumps that get made to update the @since values also get merged back to trunk after the release. This should happen automatically if the release steps in the handbook are followed, but want to make sure we're keeping an eye on it.

@felixarntz felixarntz merged commit 357b3ce into trunk Apr 5, 2024
34 checks passed
@github-actions github-actions bot temporarily deployed to wp.org plugin: speculation-rules April 5, 2024 20:15 Destroyed
@github-actions github-actions bot temporarily deployed to wp.org plugin: speculation-rules April 5, 2024 20:18 Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release [Type] Enhancement A suggestion for improvement of an existing feature
3 participants