Add Speculative Loading generator tag

[felixarntz]

Summary

Adds a generator tag to the Speculative Loading plugin, similar to how the other standalone plugins include one.

Relevant technical choices

• Uses the new plugin name per Review current plugin names and their descriptions for their accuracy and helpfulness #1046 / Update plugin names and descriptions to better describe their features #1101

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: felixarntz <flixos90@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: thelovekesh <thelovekesh@git.wordpress.org>
Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[westonruter]

Maybe take this as an opportunity to align the other functions with this one? Namely, the constant checks seem to be a vestige of the module past.

performance/plugins/dominant-color-images/hooks.php

Lines 180 to 187 in 71055b3

	function dominant_color_render_generator() {
	if (
	defined( 'DOMINANT_COLOR_IMAGES_VERSION' ) &&
	! str_starts_with( DOMINANT_COLOR_IMAGES_VERSION, 'Performance Lab ' )
	) {
	echo '<meta name="generator" content="Dominant Color Images ' . esc_attr( DOMINANT_COLOR_IMAGES_VERSION ) . '">' . "\n";
	}
	}

performance/plugins/webp-uploads/hooks.php

Lines 772 to 778 in 71055b3

	function webp_uploads_render_generator() {
	if (
	defined( 'WEBP_UPLOADS_VERSION' )
	) {
	echo '<meta name="generator" content="WebP Uploads ' . esc_attr( WEBP_UPLOADS_VERSION ) . '">' . "\n";
	}
	}

performance/plugins/embed-optimizer/hooks.php

Lines 164 to 170 in 71055b3

	function embed_optimizer_render_generator() {
	if (
	defined( 'EMBED_OPTIMIZER_VERSION' )
	) {
	echo '<meta name="generator" content="Embed Optimizer ' . esc_attr( EMBED_OPTIMIZER_VERSION ) . '">' . "\n";
	}
	}

Aside: It seems Auto Sizes is missing a generator meta tag also.

[felixarntz]

@westonruter

Maybe take this as an opportunity to align the other functions with this one? Namely, the constant checks seem to be a vestige of the module past.

Done in c6252cf

Aside: It seems Auto Sizes is missing a generator meta tag also.

Let's do that in a separate PR.

Another idea: Should we use the plugin slug instead of the plugin name for all those individual generator tags? That would be more in line with the main Performance Lab generator tag, and furthermore would avoid having to make a trade-off between using outdated plugin names vs the maintenance burden of having to adjust tooling every time we may change the plugin name.

Since those generator tags are still new and I assume aren't used much, it would probably be fine to change them once at this point to be the slug, and after that they'll be "stable" forever.

[westonruter]

Good idea! Let's use slugs. 🐌

[westonruter]

Let's do that in a separate PR.

Why? You're already in here modifying other plugins' generator meta tags. Will reduce noise to just do it all here.

[felixarntz]

Good idea! Let's use slugs. 🐌

I'll do that in a separate follow up PR, as it's a distinct change affecting several plugins in a way that I'd put it in the changelog.

Why? You're already in here modifying other plugins' generator meta tags. Will reduce noise to just do it all here.

Similar to the above, I prefer to do this separately as it would touch another plugin and should be mentioned in the changelog. It's quick anyway.

[mukeshpanchal27]

I would also like to do the follow-up work on a separate PR.