Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up outdated module references #1100

Merged
merged 6 commits into from
Mar 29, 2024
Merged

Conversation

felixarntz
Copy link
Member

@felixarntz felixarntz commented Mar 28, 2024

Summary

This PR removes or replaces all remaining "module" references that are no longer accurate. The only exceptions are changelog entries and documentation related to migrating away from modules.

  • Replaces the word "module" with "plugin" or, in a few places, another more accurate replacement.
  • Removes WebP Uploads specific FAQ items from the main Performance Lab readme.txt.
  • Renames the tests/testdata/modules directory to tests/testdata/plugins.
  • Removes a few module specific references that are no longer relevant.

This PR does not change any functionality.

@felixarntz felixarntz added Infrastructure Issues for the overall performance plugin infrastructure Creating standalone plugins [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only skip changelog PRs that should not be mentioned in changelogs labels Mar 28, 2024
@felixarntz felixarntz added this to the performance-lab 3.0.0 milestone Mar 28, 2024
Copy link

github-actions bot commented Mar 28, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: felixarntz <flixos90@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: thelovekesh <thelovekesh@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@thelovekesh
Copy link
Member

Thanks @felixarntz. This PR has some changes in the tests directory which conflicts with #1065. I request to keep any directory modifications as part of #1065 while we can edit the existing files with "modules" references in the current PR. LMKWYT?

@felixarntz
Copy link
Member Author

@thelovekesh That's fair. I have reverted the respective commit, so the directory renaming is no longer part of this PR.

@felixarntz felixarntz merged commit f782707 into trunk Mar 29, 2024
27 checks passed
@felixarntz felixarntz deleted the cleanup/module-references branch March 29, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues for the overall performance plugin infrastructure [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only skip changelog PRs that should not be mentioned in changelogs [Type] Documentation Documentation to be added or enhanced
3 participants