Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added global documentation #1005

Merged
merged 4 commits into from
Feb 27, 2024

Conversation

keyurptl
Copy link
Contributor

@keyurptl keyurptl commented Feb 21, 2024

Added Global documentation according to PHP Documentation Standards.

Fixes: #1003

Copy link

github-actions bot commented Feb 21, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @shailm@itpathsolutions.com.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: shailm@itpathsolutions.com.

Co-authored-by: keyurptl <itpathsolutions@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @keyurptl, for the PR. We don't need this global variable as it will not be used on the page. Instead of adding the document, we should remove it from the code.

Please correct me if I missed anything. Thank you!

@mukeshpanchal27 mukeshpanchal27 added [Type] Bug An existing feature is broken Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release labels Feb 23, 2024
@keyurptl
Copy link
Contributor Author

keyurptl commented Feb 23, 2024

Thanks, @keyurptl, for the PR. We don't need this global variable as it will not be used on the page. Instead of adding the document, we should remove it from the code.

Please correct me if I missed anything. Thank you!

@mukeshpanchal27 Thanks for the feedback.

I have updated changes as per mentioned.

Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @keyurptl!

Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @keyurptl for the updates. LGTM!

@mukeshpanchal27 mukeshpanchal27 merged commit 28fced3 into WordPress:trunk Feb 27, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release [Type] Bug An existing feature is broken
4 participants