FormTokenField: Deprecate bottom margin #63491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Bug
20 tasks
|
Size Change: +93 B (+0.01%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
mirka
commented
Jul 12, 2024
Comment on lines
+36
to
38
| p:not(.components-base-control__help, .components-form-token-field__help) { | ||
| margin-top: 0; | ||
| } |
There was a problem hiding this comment.
This is to maintain this margin right here, which was previously maintained implicitly due to a Spacer component inserted in the __nextHasNoMarginBottom={ false } case.
There was a problem hiding this comment.
The PostTaxonomies component is used in two places:
-
The "Tags" section of the Post sidebar.
-
In the Preferences modal.
gutenberg/packages/editor/src/components/preferences-modal/index.js
Lines 105 to 111 in 9f8014a
The usage in the Preferences modal is very strange — the callback parameters are used to render toggles 😅 Anyway, our margin changes don't affect this use case.
There was a problem hiding this comment.
This is in the Post publish panel:
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
No need to do that. Just make sure to test with both a hierarchical post type (page) and a flat one (post). You can select it from the Query Loop block settings:
|
tyxla
approved these changes
Jul 15, 2024
| deprecated( | ||
| 'Bottom margin styles for wp.editor.PostTaxonomiesFlatTermSelector', | ||
| { | ||
| since: '6.7', |
There was a problem hiding this comment.
Is this going to land in 6.7 actually?
There was a problem hiding this comment.
Yes, too late to land in 6.6.
| @@ -49,15 +49,6 @@ | |||
| } | |||
| } | |||
|
|
|||
| .block-library-query-toolspanel__filters { | |||
There was a problem hiding this comment.
We're still rendering the original classname for backward compatibility, right?
There was a problem hiding this comment.
Correct. I added a code comment b912e8b
| @@ -99,6 +100,7 @@ export const Async: StoryFn< typeof FormTokenField > = ( { | |||
| Async.args = { | |||
| label: 'Type a continent', | |||
| suggestions: continents, | |||
| __nextHasNoMarginBottom: true, | |||
There was a problem hiding this comment.
Confirmed that all stories inherit args from either of the 2 definitions that define __nextHasNoMarginBottom: true.
# Conflicts: # packages/block-library/src/query/edit/inspector-controls/author-control.js # packages/block-library/src/query/edit/inspector-controls/taxonomy-controls.js
mirka
added
[Type] Enhancement
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
* Migrate in Query Loop block inspector * Update docs * PostTaxonomiesFlatTermSelector: Deprecate bottom margin * FormTokenField: Log deprecation warning * Fixup * Add changelogs * Add comment about unused CSS class Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #39358
What?
Officially start the deprecation period for the bottom margin on
FormTokenField. And by extension, also onPostTaxonomiesFlatTermSelectorin@wordpress/editor.Why?
All the unwanted margins on non-BaseControl-based components have already been hard deprecated, but this one was straggling.
How?
The dependants of FormTokenField in this repo are the following:
wp.editor.PostTaxonomiesFlatTermSelector(publicly exported as component)wp.editor.PostTaxonomies(publicly exported as component)Out of these, changing FormTokenField margins would only affect third-party consumers in the case of
PostTaxonomiesFlatTermSelector. So for that component, we are also doing a deprecation.Testing Instructions
Screenshots or screencast
Query Loop block
You may need this diff to show all the "Filters" options in the block inspector sidebar:
The gutters in between used to be uneven and wrong. It is now uniform and correct (16px).
PostTaxonomiesFlatTermSelector
In Post sidebar:
There used to be an extra bottom margin. Now it is gone.