Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataViews: Only show elligible actions in the bulk editing menu #63473

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

youknowriad
Copy link
Contributor

closes #63472

What?

This PR updates the bulk editing menu in the dataviews to only show the actions that can be applied to the current selection (or part of the current selection). Showing all the registered action can lead to too many irrelevant actions.

Testing Instructions

  • Select a list of pages in the pages dataviews.
  • Open the bulk edit menu.
  • Only relevant actions are shown.
@youknowriad youknowriad added [Type] Bug An existing feature does not function as intended [Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond labels Jul 12, 2024
@youknowriad youknowriad self-assigned this Jul 12, 2024
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@jameskoster jameskoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix :)

@youknowriad youknowriad enabled auto-merge (squash) July 12, 2024 11:37
@youknowriad youknowriad merged commit b4da8fc into trunk Jul 12, 2024
69 of 70 checks passed
@youknowriad youknowriad deleted the update/dataviews-filter-actions branch July 12, 2024 11:43
@github-actions github-actions bot added this to the Gutenberg 18.9 milestone Jul 12, 2024
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Jul 18, 2024
…Press#63473)

Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond [Type] Bug An existing feature does not function as intended
2 participants