-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: added justification
option on columns block
#63459
base: trunk
Are you sure you want to change the base?
Feature: added justification
option on columns block
#63459
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @pengsteven418. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flex justification controls are already an option that can be enabled via the allowJustification
sub key of the layout
block support:
I think currently allowEditing
is removing all those layout options. But this can be refactored to be more specific using the individual support options.
2360e8b
to
b99eaed
Compare
"allowEditing": false, | ||
"allowEditing": true, | ||
"allowJustification": true, | ||
"allowVerticalAlignment": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we are adding vertical alignment using BlockControls we don't need to display it multiple times.
<BlockControls>
<BlockVerticalAlignmentToolbar
onChange={ updateAlignment }
value={ verticalAlignment }
/>
</BlockControls>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also if we remove that then vertical alignment will not be applied to individual column.
Hi, @fabiankaegy can you please review this PR, thanks. |
this person up1512001 copies other people content |
@pengsteven418 please check once before blaming someone this issue is reported by me and I have raise PR for same. |
@talldan can you please review this PR? |
What?
Why?
Fixes #63458
How?
JustifyContentControl
to columns block.Screenshots or screencast
Screen.Recording.2024-07-12.at.01.47.00.mov