-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataViews: Combine featured image and title in the posts table #63449
base: trunk
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +49 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
I'm hesitant here because most of the time, the featured image is empty so we'll have a gray square. Let's see what designers say. |
Hm... yeah. Actually for posts makes more sense than pages.. |
Agreed, although it's hard to implement :P |
{ | ||
id: 'post', | ||
header: __( 'Title' ), | ||
children: [ 'featured-image', 'title' ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if Front Page
and Posts Page
could now also be a field. Not sure if that needs to be filterable though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The features associated with making these fields don't seem particularly useful to me. Columns in particular would add weight to the table, especially as all records except one will be false.
I appreciate it would make these pages a bit easier to locate, but not in a very ergonomic way. Add filter > is posts page > true isn't the quickest flow. Some alternatives we might consider could be:
- Add a dedicated view for pages associated with settings. It would include the front page, posts page, privacy policy page (if set), products page, cart, checkout (if Woo is installed), etc.
- Include the badge in when searching. IE if I search the All pages view for 'Front page', 'homepage', etc. then the static homepage should be listed even if the title doesn't contain those words.
Edit: I suppose they could be coded as fields, but 'hidden' in the UI except for the badge that exists today. Apologies if that was the implied idea and I went off on a tangent :)
Fixes #58012
What?
This PR combines the "title" with the "featured image" fields in the "pages" dataviews.
Testing Instructions
1- Open the pages dataviews page
2- Check that the featured image is combined with the "title" field in the table layout