-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zoom Out: Ensure that we only enter zoom out mode if the experiment is enabled #63417
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +3 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
What?
Don't trigger zoom out unless you have the experiment enabled.
Why?
If the experiment setting is unchecked then
window.__experimentalEnableZoomedOutPatternsTab
isundefined
and thereforeshowZoomOut
isundefined
which means thatuseZoomOut
triggers zoom out mode.How?
Add a double bang to
window.__experimentalEnableZoomedOutPatternsTab
so thatshowZoomOut
evaluates to either true or false.Testing Instructions
wp-admin/admin.php?page=gutenberg-experiments
wp-admin/admin.php?page=gutenberg-experiments