Revert triggering multi-entity save panel in post with meta changes #63412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantosGuillamot
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -47 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
I've tested and confirmed this resolves the issues I reported in #63355 🥳 |
SantosGuillamot
added
the
Backport to WP Minor Release
cbravobernal
deleted the
fix/revert-triggering-multi-entity-save-panel-in-meta-changes
branch
This was referenced Jul 11, 2024
|
Thank you! Should we close the linked issues that are resolved with this PR? |
I closed mine as fixed and referenced the next steps ticket (#63425) - but the others probably need reviewing to see if they are solved by the rollback, or at least need to be added to #63425 so it's tracked when this flow is readded |
|
I left a comment on the remaining issue, which is cover in #63425 |
41 tasks
ellatrix
added
the
Backport to WP 6.6 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Jul 15, 2024
…63412) * Revert showing multi-entity panel in meta changes * Remove test "should show panel and indicator when metadata has been modified" Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org> Co-authored-by: cbravobernal <cbravobernal@git.wordpress.org> Co-authored-by: lgladdy <lgladdy@git.wordpress.org>
github-actions
bot
added
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.6 branch to get it included in the next release: cda3b87 |
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Jul 15, 2024
This package update includes only one revert PR: WordPress/gutenberg#63412 You can confirm the changes in this package update here: https://github.com/WordPress/gutenberg/commits/wp/6.6/ Fixes #61654. Props santosguillamot. git-svn-id: https://develop.svn.wordpress.org/trunk@58719 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Jul 15, 2024
This package update includes only one revert PR: WordPress/gutenberg#63412 You can confirm the changes in this package update here: https://github.com/WordPress/gutenberg/commits/wp/6.6/ Fixes #61654. Props santosguillamot. Built from https://develop.svn.wordpress.org/trunk@58719 git-svn-id: http://core.svn.wordpress.org/trunk@58121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Jul 15, 2024
This package update includes only one revert PR: WordPress/gutenberg#63412 You can confirm the changes in this package update here: https://github.com/WordPress/gutenberg/commits/wp/6.6/ Fixes #61654. Props santosguillamot. Built from https://develop.svn.wordpress.org/trunk@58719 git-svn-id: https://core.svn.wordpress.org/trunk@58121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Jul 15, 2024
This package update includes only one revert PR: WordPress/gutenberg#63412 You can confirm the changes in this package update here: https://github.com/WordPress/gutenberg/commits/wp/6.6/ Reviewed by ellatrix, audrasjb. Merges [58719] to the 6.6 branch. Fixes #61654. Props santosguillamot. git-svn-id: https://develop.svn.wordpress.org/branches/6.6@58720 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Jul 15, 2024
This package update includes only one revert PR: WordPress/gutenberg#63412 You can confirm the changes in this package update here: https://github.com/WordPress/gutenberg/commits/wp/6.6/ Reviewed by ellatrix, audrasjb. Merges [58719] to the 6.6 branch. Fixes #61654. Props santosguillamot. Built from https://develop.svn.wordpress.org/branches/6.6@58720 git-svn-id: http://core.svn.wordpress.org/branches/6.6@58122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
ellatrix
removed
the
Backport to WP Minor Release
Debarghya-Banerjee
pushed a commit
to Debarghya-Banerjee/wordpress-develop
that referenced
this pull request
Jul 18, 2024
This package update includes only one revert PR: WordPress/gutenberg#63412 You can confirm the changes in this package update here: https://github.com/WordPress/gutenberg/commits/wp/6.6/ Fixes #61654. Props santosguillamot. git-svn-id: https://develop.svn.wordpress.org/trunk@58719 602fd350-edb4-49c9-b593-d223f7449a82
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
…ordPress#63412) * Revert showing multi-entity panel in meta changes * Remove test "should show panel and indicator when metadata has been modified" Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org> Co-authored-by: cbravobernal <cbravobernal@git.wordpress.org> Co-authored-by: lgladdy <lgladdy@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In this pull request, we are triggering the multi-entity save panel when users make changes to post meta, even if just that specific post has changed. That doesn't seem right and it is causing some issues:
I'm reverting part of the changes of that pull request to stop triggering the multi-entity save panel when only the current post has been modified. We should think about it more broadly and potentially define a similar workflow for "single-entity" changes if wanted.
I kept the notice of post meta changes when posts are updated in a different entity, but I can revert that as well if desired.
Related conversation in WordPress Slack: link.
Why?
Because it is causing more issues than benefits right now.
How?
I'm just reverting the changes that trigger the panel when post meta changes, as well as the test that was added in that PR.
Issues
This is the before and after of the mentioned issues:
Before
Before.revert.mp4
After
After.revert.mp4
Before
Lock.before.revert.mp4
After
Lock.after.revert.mp4
Testing Instructions
You can use the following snippet to lock the button: