DataViews: Cleanup preview styles #63365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Code Quality
|
In comparing the Templates, Pages, and Patterns data views I see no difference between this PR and Trunk 👍 |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -63 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
I didn't notice something different visually and it's good to have this css rule removed. I'm not sure if something have changed over time from the PR that introduced it, but it seems to me I'd have tried a change in width instead of having this rule, that I'd commented I didn't like it. 😄
Anyway, thank you!
|
I'm now wondering if my build failed during testing because I'm seeing some regressions that might be related to this PR? In grid layout the featured image doesn't fill the container: 
In table layout the featured image is incorrectly sized with mismatching corner radius: 
|
|
Yes, I'm seeing a few issues myself I'll look into it. |
|
@jameskoster Reverting this change doesn't solve the issue, so It's either something else or it was always broken kind of. |
|
Ok, so it's a small mistake I made in #63334 |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #55083
What?
I found these styles in the dataviews table view and I was wondering what was their purpose and by reading the git history, it seems mostly needed to render the "previews" properly in the table view of the templates dataviews.
This PR clean up these styles in favor of a simple style that applies only to the preview field rather than impacting all the fields.
Testing Instructions
1- Toggle preview field in the templates table o
2- Try the preview field in other layouts too.