Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only add customizer additional CSS to global styles in block themes #63331

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

tellthemachines
Copy link
Contributor

What?

Fixes bug spotted in the core sync PR for #62357.

Testing Instructions

  1. Activate a classic theme.
  2. In the customizer, add some additional CSS that causes immediate visual change such as body background-color.
  3. In this PR branch, the change should be reflected in the preview straightaway. (In trunk, the preview doesn't update as it should.)

Screenshots or screencast

Screenshot 2024-07-10 at 2 47 19 PM
@tellthemachines tellthemachines added CSS Styling Related to editor and front end styles, CSS-specific issues. Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core labels Jul 10, 2024
@tellthemachines tellthemachines self-assigned this Jul 10, 2024
Copy link

github-actions bot commented Jul 10, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org>
Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@aaronrobertshaw aaronrobertshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tellthemachines 👍

The change here matches the fix in WordPress/wordpress-develop#6750 and tests well for me here also.

Before After
Screen.Recording.2024-07-10.at.2.58.21.PM.mp4
Screen.Recording.2024-07-10.at.2.58.45.PM.mp4
Copy link
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! This is testing nicely for me, too. Just left a tiny whitespace nit, but otherwise LGTM 🚀

lib/script-loader.php Outdated Show resolved Hide resolved
Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com>
@tellthemachines tellthemachines enabled auto-merge (squash) July 10, 2024 06:23
@andrewserong andrewserong added the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Jul 10, 2024
@tellthemachines tellthemachines merged commit ac01698 into trunk Jul 10, 2024
65 checks passed
@tellthemachines tellthemachines deleted the fix/classic-theme-customizer branch July 10, 2024 06:58
@github-actions github-actions bot added this to the Gutenberg 18.9 milestone Jul 10, 2024
huubl pushed a commit to huubl/gutenberg that referenced this pull request Jul 10, 2024
…ordPress#63331)

Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org>
Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
andrewserong added a commit that referenced this pull request Jul 15, 2024
…63331)

Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org>
Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
@andrewserong
Copy link
Contributor

I just cherry-picked this PR to the release/18.8 branch to get it included in the next release: 5ce11d9

@andrewserong andrewserong removed the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Jul 15, 2024
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Jul 18, 2024
…ordPress#63331)

Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org>
Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core CSS Styling Related to editor and front end styles, CSS-specific issues.
3 participants