Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimePicker: Fix time zone overflow #63209

Merged
merged 2 commits into from
Jul 8, 2024
Merged

TimePicker: Fix time zone overflow #63209

merged 2 commits into from
Jul 8, 2024

Conversation

mirka
Copy link
Member

@mirka mirka commented Jul 5, 2024

What?

Fixes a style regression introduced in #60613 where the time zone in the TimePicker was overflowing a bit.

This was especially noticeable in the "Date" block:

Time zone overflowing in popover

How?

Remove the width: 100% style in the container element, by adding a expanded={ false } prop to HStack.

Testing Instructions

Compare the result in the Storybook for TimePicker. Or, in the editor, the post publish popover or the "Date" block.

Screenshots or screencast

Before After
Time zone is overflowing Time zone is in correct position
@mirka mirka added [Type] Bug An existing feature does not function as intended [Package] Components /packages/components labels Jul 5, 2024
@mirka mirka self-assigned this Jul 5, 2024
@mirka mirka requested a review from ajitbohra as a code owner July 5, 2024 20:43
Copy link

github-actions bot commented Jul 5, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the fix 🚀

@mirka mirka merged commit 98f08cf into trunk Jul 8, 2024
63 checks passed
@mirka mirka deleted the fix/time-picker-overflow branch July 8, 2024 12:09
@github-actions github-actions bot added this to the Gutenberg 18.8 milestone Jul 8, 2024
huubl pushed a commit to huubl/gutenberg that referenced this pull request Jul 10, 2024
* TimePicker: Fix time zone overflow

* Add changelog

Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org>
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Jul 18, 2024
* TimePicker: Fix time zone overflow

* Add changelog

Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Bug An existing feature does not function as intended
2 participants