-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in string for trashing posts #63119
Conversation
Size Change: -10 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
Recently I had updated these strings to be more generic and use items
instead of pages
or posts
. So the extra check you're removing here is the way to go.
You can test this in pages list in site editor by bulk moving to trash pages.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: knutsp <knutsp@git.wordpress.org>
I just cherry-picked this PR to the wp/6.6 branch to get it included in the next release: 8fb9836 |
Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: knutsp <knutsp@git.wordpress.org>
What?
Fixes #63113
There's a typo in a string "%s items move to trash.".
How?
There's an identical (but correctly spelt) translation a few lines above that uses
_n
, so I've merged the two conditions.Hopefully this means the PR is ok to merge during the string freeze, seeing as no strings were added.
Testing Instructions
I'm not sure how to test this, I couldn't find a place in the UI that it's used.