[WIP] Support both experimental and non-experimental typography supports in JS #63072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Enhancement
andrewserong
commented
Jul 3, 2024
| }; | ||
|
|
||
| // Stabilize the style property support keys by mapping experimental supports to stable supports. | ||
| const STYLE_PROPERTY = Object.keys( RAW_STYLE_PROPERTY ).reduce( |
There was a problem hiding this comment.
Note: I've added this here instead of updating the STYLE_PROPERTY directly in api/constants as unfortunately the constants are exported publicly. If we think it's safe to change, I can update that file directly instead of this part of the change. Here's the original file:
gutenberg/packages/blocks/src/api/constants.js
Lines 17 to 272 in 02c6a8f
andrewserong
commented
Jul 3, 2024
| @@ -93,6 +130,36 @@ function filterElementBlockSupports( blockSupports, name, element ) { | |||
| } ); | |||
| } | |||
|
|
|||
| function getStableBlockSupports( blockType ) { | |||
There was a problem hiding this comment.
TODO: Add a comment explaining what this does (treats experimental typography keys as non-experimental)
|
Size Change: +281 B (+0.02%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
Update: while this technically works, it's a bit fiddly. @aaronrobertshaw had the good suggestion to try updating Specifically, the place to do the processing is likely in This work is a little on the backburner for me, so I won't get around to it immediately, but my next step will be try that idea out (likely in a separate PR) so we can explore the different options (hopefully by sometime next week). |
andrewserong
changed the title
|
Just chatted with @aaronrobertshaw some more about the ideas here, and for a potential approach on a neater way to handle this. Ideas to try next:
|
|
Just closing this out now as I've made a start on an alternative implementation over in #63401, which seems promising. I've only done the JS changes for now, but I'll continue on with the PHP logic next week. Thanks again for the tips, Aaron! 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
🚧 🚧 🚧 🚧 Early exploration into stabilizing the Typography block supports, not yet ready for testing 🚧 🚧 🚧 🚧
Part of #63001
Allow support for the following typography block supports in both JS and PHP logic:
__experimentalFontFamily→fontFamily__experimentalTextDecoration→textDecoration__experimentalFontStyle→fontStyle__experimentalFontWeight→fontWeight__experimentalLetterSpacing→letterSpacing__experimentalTextTransform→textTransform__experimentalWritingMode→writingModeWhy?
To enable blocks to opt in to typography supports without needing to use the
__experimentalprefix. At the same time, we need to support any block plugins out in the wild that still use the experimental prefix, so support will likely need to be maintained in perpetuity.How?
TBC
To-do
usePasteStylesworks as expectedTesting Instructions
TBC
Testing Instructions for Keyboard
Screenshots or screencast