Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components: Split stories and test files into separate projects #63045

Draft
wants to merge 7 commits into
base: trunk
Choose a base branch
from
Draft

Components: Split stories and test files into separate projects #63045

wants to merge 7 commits into from

Conversation

sirreal
Copy link
Member

@sirreal sirreal commented Jul 2, 2024 •
edited
Loading

What?

I did some TypeScript analysis and found that most TypeScript compilation time is spent on the components package. Some very costly compilation was in stories.

Why?

I wanted to try to split out stories (and tests) for a few reasons:

  • The use an environment that is not suitable for application code with jest, node, and other globals.
  • There's no reason to emit anything (including declarations) for stories and tests. We can typecheck them, but nothing consumes the types so we can save the emit.

How?

Split into a separate project.

Testing Instructions

CI passes.
Look at some stories in an editor with TypeScript integration. Does everything seem OK?
@sirreal sirreal force-pushed the update/split-components-test-stories-ts-project branch from 91bd058 to 5762906 Compare July 2, 2024 10:13
@sirreal sirreal force-pushed the update/split-components-test-stories-ts-project branch from dfbc871 to 390ae88 Compare July 2, 2024 12:26
@sirreal sirreal added the [Type] Code Quality Issues or PRs that relate to code quality label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality
1 participant
@sirreal