Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Change dropdown button label to 'screen options.' #63031

Merged
merged 4 commits into from
Jul 5, 2024

Conversation

vipul0425
Copy link
Contributor

What?

Fixes: #63029

Testing Instructions

  • Go to the Site Editor > Pages.
  • At the top of the pages list, hover or focus the View Options icon button.
  • Observe the button label should be... Screen options.
  • test with languages other than English, Spanish or Italian and please report in the comments below all the incorrect translations you may find.
Copy link

github-actions bot commented Jul 1, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: vipul0425 <vipulgupta003@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: afercia <afercia@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@amitraj2203 amitraj2203 added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). l10n Localization and translations best practices [Package] DataViews /packages/dataviews labels Jul 1, 2024
vipul0425 and others added 2 commits July 4, 2024 01:14
Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks @vipul0425 🙌

Let's hold off merging this as #63029 still needs consensus on whether this is the best way forward.

Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a consensus on moving forward with a contextual improvement for translators, so this is good to ship 👍

Thanks for your help @vipul0425 🙌

@tyxla tyxla enabled auto-merge (squash) July 5, 2024 09:38
@tyxla tyxla merged commit 0329f63 into WordPress:trunk Jul 5, 2024
59 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.8 milestone Jul 5, 2024
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Jul 18, 2024
* fix: Change dropdown button label to 'screen options.'

* Update packages/dataviews/src/view-actions.tsx

Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>

* fix: Imports the package.

---------

Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>

Co-authored-by: vipul0425 <vipulgupta003@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: afercia <afercia@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). l10n Localization and translations best practices [Package] DataViews /packages/dataviews [Type] Bug An existing feature does not function as intended
3 participants