Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix double check in isTemplateRemovable #63021

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Fix double check in isTemplateRemovable #63021

merged 1 commit into from
Jul 1, 2024

Conversation

ntsekouras
Copy link
Contributor

@ntsekouras ntsekouras added the [Type] Code Quality Issues or PRs that relate to code quality label Jul 1, 2024
@ntsekouras ntsekouras self-assigned this Jul 1, 2024
@ntsekouras ntsekouras mentioned this pull request Jul 1, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.
youknowriad
youknowriad approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
@ntsekouras ntsekouras enabled auto-merge (squash) July 1, 2024 12:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024

Flaky tests detected in 0b46f0e.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9744214221
📝 Reported issues:
@ntsekouras ntsekouras merged commit 2e367a1 into trunk Jul 1, 2024
67 checks passed
@ntsekouras ntsekouras deleted the fix/double-check-istemplateremovable branch July 1, 2024 13:04
@github-actions github-actions bot added this to the Gutenberg 18.8 milestone Jul 1, 2024
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Jul 18, 2024
@ntsekouras @youknowriad @carstingaxion
Fix double check in isTemplateRemovable (WordPress#63021)
b995557 
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality
2 participants
@ntsekouras @youknowriad