Device previews: avoid needless overflow and include bottom margin in overflow #62989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stokesman
added
the
[Type] Regression
|
Size Change: -22 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
stokesman
force-pushed
the
fix/device-preview-scroll
branch
from
6923b96
to
8b7b418
Compare
|
I still think it’s likely the device previews should be restored to how they were in 6.5 but I'm closing this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A fix to make the device previews work as shipped in 6.5.
Why?
Currently device previews create vertical overflow/scrollbars in the interface content area even if the area is taller than the device preview. Additionally, when the content area is shorter, the overflow doesn’t contain the bottom margin of the device preview (as it did in 6.5).
How?
Making it so the bottom margin of the device preview (iframe) is not clipped by removing the
overflow: hiddenrule onVisualEditor. That would regress another recently fixed issue #62894, so the overflow of block toolbars is prevented with inline styles onBlockTools. There’s a bit more to it but I’ll add detail here or in review comments later.Testing Instructions
Also do a general smoke test of things like:
Screenshots or screencast
Device preview in 6.5
device-preview-6.5.mov
I'll add comparison recording of trunk later, this branch should be just like the one above.