-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Bindings: Replace useSelect
hook that calls no selectors with useMemo
#62956
Conversation
Size Change: -2 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
Tests are failing, so that indicates this breaks things. 🤔 edit: though only one test. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
It looks like |
I was just gonna share something similar 🙂 Thanks a lot for exploring this option! Maybe it is worth adding a comment in the code as well? |
Yep, I'll make a small PR that does that 👍 Done in #63005 |
What?
Small PR that updates what I think was originally a typo, replacing
useSelect
withuseMemo
Why?
I couldn't see any reason to use
useSelect
. Either the selectors were refactored away, or it was intended to be auseMemo
.Testing Instructions
There's no impact, apart from maybe some very minor performance gains?