Featured Image Panel: Align text and icons horizontally to avoid clipping #62842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: +96 B (+0.01%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
I'm not sure if this PR can be backported to WP6.6 now, but I'll label it just in case. |
t-hamano
added
the
Backport to WP 6.6 Beta/RC
jasmussen
approved these changes
Jun 25, 2024
Good suggestion, updated 👍 47c13f94eb402b29316f14d31ce01050.mp4 |
github-actions
bot
removed
the
Backport to WP 6.6 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Jun 26, 2024
…ping (#62842) * Featured Image Panel: Align text and icons horizontally to avoid clipping * Apply rounded corner to drop zone Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.6 branch to get it included in the next release: b5d75a0 |
andrewserong
added
the
[Feature] Drag and Drop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62841
What?
This PR prevents text and icons from being cut off when you drag an image when a featured image has not yet been set.
How?
Positions the icon and text horizontally only if an image has not yet been set.
If a featured image is set,
.editor-post-featured-image__toggleis applied to the button, otherwise.editor-post-featured-image__previewis applied. However, since theDropZoneis placed next to this button, theDropZonecomponent itself cannot know whether a featured image is set or not. Therefore, I used the:haspseudo selector.Testing Instructions
Open the post editor.
Move the file to the "Set featured Image" button.
Screenshots or screencast
5dfac7dd424e96e6d72de8014b160860.mp4