-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit support for image block height and width #62750
base: trunk
Are you sure you want to change the base?
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +35 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
Flaky tests detected in 91ef647. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9614952531
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
The point of this problem is, as this comment indicates, that the ResizableBox
and ImageEdit
components assume px
units.
Therefore, this PR works on the frontend but not in the editor.
I don't have any good ideas at the moment, but we need to solve this problem first.
bf8eccbb2d796a585d6429443c12b7ce.mp4
Thank you @t-hamano for insight. I see, that's why it just had a PX unit till now, and because the featured image block isn't resizable, it has another unit in the width/height controls. |
Cover block also has same functionality where min-height unit changed to PX unit whenever Edit-Post-.Hello-World-.-.-gutenberg-.-WordPress.webm |
What?
Fixes #55059
Why?
Width/height control have only
PX
unit enabled in Image block settings.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast