Interactivity API: Refactor internal proxy and signals system #62734
+2,555
−420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DAreRodz
added
[Type] Enhancement
|
Size Change: +4.95 kB (+0.28%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
DAreRodz
force-pushed
the
try/iapi-proxies-refactoring
branch
from
643b333
to
4b66d89
Compare
|
Flaky tests detected in ebbe873. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10146436572
|
DAreRodz
force-pushed
the
try/iapi-proxies-refactoring
branch
3 times, most recently
from
2f0562a
to
46fa744
Compare
22 tasks
DAreRodz
force-pushed
the
try/iapi-proxies-refactoring
branch
2 times, most recently
from
1997db5
to
2252f8b
Compare
2 tasks
2 tasks
|
@DAreRodz I have linked this issue to be closed when this pull request is merged with a test that makes sure that plain arrays cannot be used at the root of the context. |
DAreRodz
force-pushed
the
try/iapi-proxies-refactoring
branch
3 times, most recently
from
848e40a
to
947b8d8
Compare
DAreRodz
commented
Jul 24, 2024
DAreRodz
commented
Jul 24, 2024
DAreRodz
commented
Jul 24, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Co-authored-by: Luis Herranz <luisherranz@gmail.com>
Co-authored-by: Luis Herranz <luisherranz@gmail.com>
DAreRodz
force-pushed
the
try/iapi-proxies-refactoring
branch
from
3eea771
to
28d329b
Compare
|
Luis, I've addressed all the actionable feedback you shared. Feel free to take a look at the PR again. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The main goal of this refactoring is to have more control when defining state/context properties. The idea is to keep a unique computed for each of these properties per scope, which tracks changes even when its value is replaced with a getter. This way, properties can contain an initial value and be replaced with a getter later on or vice-versa, ensuring that directives update accordingly in this case. This is especially relevant for stores that are loaded asynchronously, like the
core/routerstore from the@wordpress/interactivity-routermodule.Also, we can take this opportunity to remove an external dependency (deepsignal), keeping the code specific to the Interactivity API and making it more maintainable.
Tasks
peek()Next
I think these tasks should be addressed in a subsequent PR:
Testing Instructions
No testing instructions yet.