Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Management Automation: Update action to run on node20 #62695

Closed
wants to merge 1 commit into from

Conversation

sirreal
Copy link
Member

@sirreal sirreal commented Jun 20, 2024

What?

Use node20, not the very old, deprecated node12.

Why?

node12 is outdated, unsupported, and deprecated.

Other PRs will have warnings, see an example.

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20 …
The following actions uses node12 which is deprecated and will be forced to run on node16 …

How?

Update the action.

Testing Instructions

See it run on CI. I'm not sure why there's still a node12 warning, maybe that will go away after this is landed.

@sirreal sirreal added [Package] Project management automation /packages/project-management-automation [Type] Code Quality Issues or PRs that relate to code quality labels Jun 20, 2024
@sirreal sirreal marked this pull request as ready for review June 20, 2024 11:16
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: sirreal <jonsurrell@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@sirreal sirreal requested review from desrosj and gziolo June 20, 2024 11:16
@sirreal sirreal force-pushed the update/project-management-action-node-20 branch from 3c8c996 to 8958ff8 Compare June 20, 2024 11:40
@sirreal sirreal force-pushed the update/project-management-action-node-20 branch from 8958ff8 to 16104e3 Compare June 28, 2024 11:55
@sirreal
Copy link
Member Author

sirreal commented Jun 28, 2024

#62851 did this.

@sirreal sirreal closed this Jun 28, 2024
@sirreal sirreal deleted the update/project-management-action-node-20 branch June 28, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Project management automation /packages/project-management-automation [Type] Code Quality Issues or PRs that relate to code quality
1 participant