Fix: a11y text for site editor

[up1512001]

What?

• updated aria label text as site text

Why?

Fixes #62644

How?

• using site title for aria label label={ decodeEntities( siteTitle ) }

Screenshots or screencast

Screen.Recording.2024-06-18.at.23.00.18.mov

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: up1512001 <up1512001@git.wordpress.org>
Co-authored-by: afercia <afercia@git.wordpress.org>
Co-authored-by: richtabor <richtabor@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[youknowriad]

I think @richtabor worked on this recently, so this might be a design regression a bit.

[afercia]

Please see inline comments.

[up1512001]

@afercia addressed your feedback please review the PR.

[up1512001]

@afercia updated as per your feedback. please check.

[richtabor]

I think @richtabor worked on this recently, so this might be a design regression a bit.

Yes, let's resolve the a11y feedback apart from icon changes.

The ExternalLink component has been updated to leverage the ↗ unicode character. This is intended to share the same DNA as that component, as it is also a text only external link.

[up1512001]

@richtabor @afercia I have reverted style-related changes and only kept accessibility related changes.

[afercia]

@up1512001 thank you. Looks good to me 👍🏽
I will creat a follow-up issue for the ↗ CSS pseudo element.

[afercia]

LGTM

[up1512001]

@afercia I thought we should use the wordpress icon for consistency instead of the after pseudo element so whenever the icon is updated it will reflect to everywhere.
Let me know your thoughts.

[afercia]

+1 when @richtabor approves.

[afercia]

@afercia I thought we should use the wordpress icon for consistency instead of the after pseudo element so whenever the icon is updated it will reflect to everywhere.

@up1512001 personally I don't like the design of this component and I don't understand the need to replace the external icon with the North East Arrow unicode character. If it was up to me, I would change it but hte prevalent opinion from design is to keep the arrow so yes, fair enough 🙂

[richtabor]

I don't understand the need to replace the external icon with the North East Arrow unicode character.

It's much more palatable when placed directly alongside text. The external icon was too big and disorienting when in those placements. Making it smaller made it less communicative/complex.

I'm fine if we do the unicode symbol as an icon, resulting in no change visually.

[afercia]

Making it smaller made it less communicative/complex.

Making it smaller made it also less readable. See #62832 for a more in depth analysis.

[up1512001]

Hi @richtabor any feedback for this PR?