remove: unnessary theme installation at docker setup

[up1512001]

What?

This PR removes TT4, TT3 and TT1 theme installation when running npm run wp-env start as we are already getting all default themes from WordPress.

Why?

#62491

How?

remove unnecessary theme installations from .wp-env.json file.

Screenshot after modifying .wp-env.json

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: up1512001 <up1512001@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Co-authored-by: vcanales <vcanales@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: talldan <talldanwp@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @up1512001! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

[youknowriad]

I think these themes are actually used in performance tests no?

[youknowriad]

I think if we remove these, the performance tests in CI might still run but locally, you'll have issues running these. cc @oandregal

[up1512001]

@youknowriad but when I see that under the test folder all three theme folders are empty even before this modification also 🤔

[vcanales]

They're being downloaded in the test environment, and they're used here:

gutenberg/bin/plugin/commands/performance.js

Lines 422 to 430 in 57b8b61

	'wp-content/themes/gutenberg-test-themes':
	path.join(
	testRunnerDir,
	'test/gutenberg-test-themes'
	),
	'wp-content/themes/gutenberg-test-themes/twentytwentyone':
	'https://downloads.wordpress.org/theme/twentytwentyone.1.7.zip',
	'wp-content/themes/gutenberg-test-themes/twentytwentythree':
	'https://downloads.wordpress.org/theme/twentytwentythree.1.0.zip',

[up1512001]

@youknowriad I run a performance test locally and it's working fine.
npm run test:performance

[t-hamano]

This was added in #50905, but the purpose seems to be to keep theme versions consistent across performance tests.

[vcanales]

Regarding the original issue, #62491, are you going to the site on port 8888 (development) or 8889 (test)? I usually do my local manual testing on the development site, since 8889 is used by automation. I can reproduce your issue, but I also expect the test site to have its own quirks.

➜  gutenberg git:(trunk) npm run wp-env start -- --xdebug=profile,trace,debug

> gutenberg@18.5.0 wp-env
> wp-env start --xdebug=profile,trace,debug

WordPress development site started at http://localhost:8888 # I use this one for development
WordPress test site started at http://localhost:8889

Perhaps we're lacking a bit of cleanup on the test site, though.

[up1512001]

I check on the 8889 port. @vcanales

[up1512001]

Still, one strange thing why the TT4, TT3 and TT1 folders are empty even after running the performance test?
cc: @vcanales @youknowriad

[talldan]

I check on the 8889 port.

It's recommended to use 8888 for anything you're doing manually, 8889 is for running tests. Those automated tests expect a clean environment, so you should avoid changing stuff in the WordPress instance there. When you run the tests, they'll also do some clean up like deleting posts, sometimes patterns, or even resetting styles, which is something you might not want to happen.

[up1512001]

I guess we should update the performance test to run on the latest version to avoid duplicate theme installation.