Cherry pick script: make authenticated requests #62473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the 6.6 Beta 2 release, we ran into rate limiting issues due to conflicts that had to be resolved, which meant that we had to run the script multiple times. Non-authenticated requests have a 60 per hour limit. In order to avoid it in the future, we can grab the token generated by `gh` and use it to make authenticated requests instead, which have a 5000-per hour limit. ```sh ➜ gutenberg git:(trunk) curl -vvvv --request GET \ --url "https://api.github.com/octocat" \ --header "Authorization: Bearer <TOKEN_GENERATED_BY_GH_CLI>" \ --header "X-GitHub-Api-Version: 2022-11-28" ... < HTTP/2 200 < server: GitHub.com < date: Tue, 11 Jun 2024 10:36:15 GMT < content-type: application/octocat-stream < content-length: 917 < x-github-api-version-selected: 2022-11-28 < x-ratelimit-limit: 5000 < x-ratelimit-remaining: 4992 ```
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
I've tested this running the script on a dummy label, and logging the rate limit header on the requests: // print response headers
console.log( 'Rate limit: ' + response.headers.get( 'X-RateLimit-Limit' ) );output: |
vcanales
force-pushed
the
try/improve-cherry-pick-script
branch
from
e4f4e68
to
e0584b0
Compare
|
I'll cherry-pick this on the release branch to try it. |
|
I tested this in #62641 and it works great. |
ellatrix
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Make authenticated requests to the GitHub API.
Why?
During the 6.6 Beta 2 release, we ran into rate limiting issues due to conflicts that had to be resolved, which meant that we had to run the script multiple times.
Non-authenticated requests have a 60 per hour limit, even on public endpoints.
How?
In order to avoid it in the future, we can grab the token generated by
ghand use it to make authenticated requests instead, which have a 5000-per hour limit.Testing Instructions
Testing Instructions for Keyboard