Global Styles: Prevent duplicate block style variations CSS #62465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Bug
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core GitHub repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/block-supports/block-style-variations.php ❔ lib/class-wp-theme-json-gutenberg.php ❔ phpunit/class-wp-theme-json-test.php |
|
Flaky tests detected in e1514bd. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9514841936
|
aaronrobertshaw
force-pushed
the
remove/duplicate-block-style-variation-css
branch
from
e9441f2
to
b4dc34a
Compare
|
Size Change: +18 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
aaronrobertshaw
force-pushed
the
remove/duplicate-block-style-variation-css
branch
2 times, most recently
from
15e8087
to
8fb3105
Compare
|
While backporting this one I found there's a difference between Gutenberg's and Core's |
aaronrobertshaw
force-pushed
the
remove/duplicate-block-style-variation-css
branch
from
a10b31e
to
9801d67
Compare
|
I tracked the divergence between Core and Gutenberg As No further changes on that front should be required here, so I'll flag this one ready for review. |
aaronrobertshaw
requested review from
tellthemachines,
spacedmonkey and
ellatrix
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
The test failures appear unrelated so I've kicked off a re-run of those tests. If they don't pass, I'll dig into them first thing tomorrow. |
aaronrobertshaw
force-pushed
the
remove/duplicate-block-style-variation-css
branch
from
9801d67
to
3c2de51
Compare
aaronrobertshaw
force-pushed
the
remove/duplicate-block-style-variation-css
branch
from
60194a0
to
a3be836
Compare
oandregal
approved these changes
Jun 17, 2024
huubl
pushed a commit
to huubl/gutenberg
that referenced
this pull request
Jun 17, 2024
…s#62465) Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org> Co-authored-by: oandregal <oandregal@git.wordpress.org> Co-authored-by: colorful-tones <colorful-tones@git.wordpress.org>
aaronrobertshaw
added
the
Backport to WP 6.6 Beta/RC
|
The PHP changes were backported and merged in time for 6.6 beta 3. I missed the backport label on this one for the JS changes to be cherry-picked, sorry. |
This was referenced Jun 23, 2024
ellatrix
pushed a commit
that referenced
this pull request
Jun 25, 2024
Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org> Co-authored-by: oandregal <oandregal@git.wordpress.org> Co-authored-by: colorful-tones <colorful-tones@git.wordpress.org>
|
I just cherry-picked this PR to the wp/6.6-rc-1 branch to get it included in the next release: 5d940ff |
ellatrix
added
Backported to WP Core
ellatrix
pushed a commit
that referenced
this pull request
Jun 25, 2024
Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org> Co-authored-by: oandregal <oandregal@git.wordpress.org> Co-authored-by: colorful-tones <colorful-tones@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #62457
What?
As the new section styles feature requires styles generated per application of block style variations so they can be nested, there's superfluous CSS generated in the frontend theme.json stylesheet. This PR removes that.
Why?
Less CSS.
How?
Adds option in theme json to opt out of style generation for block style variations. A similar option is added to the
useGlobalStylesOutputhook in the editor.Testing Instructions
/styles/partial.jsonCustomblock style variation.is-style-custom-*css class matchedNote: Core blocks with variations can also be used for testing, e.g. Button or Image. These blocks those also have other styles from the block library enqueued that would match. The removal of redundant CSS is clearer when testing with a custom variation.
Screenshots or screencast