-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inserter: Don't focus the inserter when opening #62444
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: -60 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
This is tricky. The ideal interaction is to not move focus when opening the panel and have the panel be the next tab stop. In our case, the panel is many tab stops from the button that opens it, so we move focus. To get consistency between panels, the other panels should autofocus the panel they open unless they are the next tab stop. |
Want to clarify that #62441 is not about handling focus, it's about the fact the focus-visible which is applied to the tab-bar component is, in this case, ignored. I'll update the issue to clarify that bit. |
Closing in favour of #62513 |
What?
This is to address: #62441
Why?
In other sidebar panels we don't automatically focus the panel, we only do it when a user interacts with the panel.
How?
Removes the code that autofocusses the inserter.
Testing Instructions