CustomSelectControlV2: Fix initial value not being set in the select for the V1 legacy adapter
#62308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…property of the `changeObject` that's passed to the `onChange` callback for the legacy adapter
…tom attributes as part of option and that they are not added to the DOM as attributes (same behavior as V1)
fullofcaffeine
added
[Package] Components
fullofcaffeine
changed the base branch from
trunk
to
fix/custom-select-control-v2-legacy-adapter-option-handling
fullofcaffeine
commented
Jun 5, 2024
| @@ -63,7 +63,8 @@ export { | |||
| useCompositeState as __unstableUseCompositeState, | |||
| } from './composite'; | |||
| export { ConfirmDialog as __experimentalConfirmDialog } from './confirm-dialog'; | |||
| export { StableCustomSelectControl as CustomSelectControl } from './custom-select-control'; | |||
| //export { StableCustomSelectControl as CustomSelectControl } from './custom-select-control'; | |||
| export { ClassicCustomSelectControlV2Adapter as CustomSelectControl } from './custom-select-control-v2/legacy-component'; | |||
There was a problem hiding this comment.
This will be reverted before merging - it's here to allow testing the V1 adapter in the GB app. We shouldn't replace the classic V1 with the legacy adapter just yet (it'll be done in a follow-up PR).
|
Size Change: +4.64 kB (+0.27%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
fullofcaffeine
removed
the
[Type] Code Quality
2 tasks
ciampo
force-pushed
the
fix/custom-select-control-v2-legacy-adapter-option-handling
branch
from
6daa4b1
to
5882f00
Compare
ciampo
force-pushed
the
fix/custom-select-control-v2-legacy-adapter-option-handling
branch
from
7a1bc5c
to
c7530a3
Compare
85 tasks
ciampo
force-pushed
the
fix/custom-select-control-v2-legacy-adapter-option-handling
branch
from
c7530a3
to
192ac71
Compare
|
Closing as superseded by #62733 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from: #61272.
Depends on: #62255.
What?
Fixes an issue in the legacy adapter where the initial
valuepassed to the select wasn't being auto-selected, effectively causing a mismatch between the store and the rendered value.Why?
Consumers expect the select to have the option defined by the
valueprop selected when it mounts, but the legacy adapter was not doing that, e.g: if you selected an option, and the component was unmounted/mounted from scratch again, it would select the first option instead of the option defined byvalue.IMPORTANT: V2 is still not replacing the classic V1 in the GB app yet. We'll eventually replace the classic export with the V1 adapter, and the commit here will be reverted before merging (it's here just to make it easier to test the adapter in the app while reviewing this PR).
How?
Ths PR fixes by making sure the value in the Ariakit store is selected upon mount from the
valuepassed.Testing Instructions
Screenshots or screencast
beforefix1.mov
afterfix1.mov
NOTE: You may notice some styling issues in the select. These were already fixed in #61272 and will be split in a follow-up PR to this one.