Global styles code quality refactoring

[ajlende]

What?

Follow-up to fix some code quality issues from WordPress/wordpress-develop#6616.

Why?

Code quality.

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ajlende <ajlende@git.wordpress.org>
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ lib/class-wp-theme-json-gutenberg.php
❔ lib/class-wp-theme-json-resolver-gutenberg.php
❔ lib/class-wp-theme-json-schema-gutenberg.php

[ramonjd]

Smoke tested the changes in a similar fashion to the Core PR testing.

Thanks a lot for the backport!

🙇🏻

[oandregal]

@ellatrix Alex prepared the backport at WordPress/wordpress-develop#6731 and I merged it at https://core.trac.wordpress.org/changeset/58339 so this doesn't have the "Backport" label. I presume you only use the label for tracking the remaining PRs to be backported, right? Let me know if there's another use and whether this PR should have it.