[Mobile] - Image corrector - Check the path extension is a valid one #62190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geriux
added
[Type] Bug
|
Size Change: +47 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
…or file: media paths
…g files as a parameter
…ith local image paths
geriux
added
the
Mobile App - Automation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
twstokes
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Thank you @geriux! Tests passed on iOS. 🚀
Is it expected that at this time on Android we can't copy from a location such as the web browser and paste into the editor? I believe I used the built-in OS clipboard and not Gboard.
We don't support pasting images from the clipboard on Android, we only support using the sharing sheet or copying an image from a Website (HTML content). I had to test to confirm it because I wasn't sure 😅
|
Thanks for the info! Then everything checks out. ✅ |
geriux
removed
the
Mobile App - Automation
geriux
added a commit
that referenced
this pull request
Jun 4, 2024
…62190) * Mobile - Image corrector - Check the path extension is a valid one * [Mobile] - Image corrector- Expand comment explaining the filtering for file: media paths * Integration Test helpers - Expand pasteIntoRichText to support passing files as a parameter * Mobile Editor Tests - Add new tests related to pasting HTML content with local image paths * Update snapshot
4 tasks
westonruter
added a commit
that referenced
this pull request
Jun 4, 2024
…dd/on-async-directives * 'trunk' of https://github.com/WordPress/gutenberg: (72 commits) Top toolbar: fix half a pixel artifacting of the bottom border. (#62225) Fix UI order for theme.json spacing sizes (#62199) Chore: Simplify a padding style on global styles. (#62291) Editor: Avoid remounts of `DocumentBar` (#62214) Add `default-spacing-sizes` and `default-font-sizes` options for classic themes (#62252) Editor: Cleanup styles and classnames (#62237) Scripts: Pin the @wordpress/scripts version to a version supported by WP 6.5 (#62234) Documentation: Better changelogs for the JSX transform upgrade (#62265) Chore: Simplify a padding style on dataviews. (#62276) MediaUpload: Remove dialog markup on close (#62168) Tabs: Prevent accidental overflow in indicator (#61979) Make edit site pagination buttons accessibly disabled. (#62267) Fix: Remove unused code from dataviews styles. (#62275) Re-enable React StrictMode (#61943) Inserter: Return the same items when the state and parameters don't change (#62263) Update instances of text-wrap: pretty to fall back to balance (#62233) Update: Slotfill documentation samples (links, code, and rephrase). (#62271) Try: Fix mover positioning. (#62226) [Mobile] - Image corrector - Check the path extension is a valid one (#62190) Update: Block styles documentation. ...
geriux
added a commit
that referenced
this pull request
Jun 5, 2024
* Release script: Update react-native-editor version to 1.119.0 * Release script: Update CHANGELOG for version 1.119.0 * Release script: Update podfile * [Mobile] - Image corrector - Check the path extension is a valid one (#62190) * Mobile - Image corrector - Check the path extension is a valid one * [Mobile] - Image corrector- Expand comment explaining the filtering for file: media paths * Integration Test helpers - Expand pasteIntoRichText to support passing files as a parameter * Mobile Editor Tests - Add new tests related to pasting HTML content with local image paths * Update snapshot * [Mobile] - Unsupported block - UI improvements (#62240) * Mobile - Unsupported block editor - Update editor style overrides * Mobile - Unsupported block - Update UI to show Tap to edit for unsupported blocks, simplifying the flow to open the Unsupported block editor * Fix unsupported block condition * Update snapshot * Fix condition for the help icon * Release script: Update react-native-editor version to 1.119.1 * Release script: Update CHANGELOG for version 1.119.1 * Release script: Update podfile * Update Unsupported Block Editor condition and reverts the functionality to select the block first before opening the editor. * Update snapshot * Update package-lock.json --------- Co-authored-by: twstokes <twstokes@git.wordpress.org> Co-authored-by: geriux <geriux@git.wordpress.org> Co-authored-by: fluiddot <carlosgprim@git.wordpress.org>
geriux
added a commit
that referenced
this pull request
Jun 6, 2024
…62190) * Mobile - Image corrector - Check the path extension is a valid one * [Mobile] - Image corrector- Expand comment explaining the filtering for file: media paths * Integration Test helpers - Expand pasteIntoRichText to support passing files as a parameter * Mobile Editor Tests - Add new tests related to pasting HTML content with local image paths * Update snapshot
geriux
added a commit
that referenced
this pull request
Jun 6, 2024
* [Mobile] - Image corrector - Check the path extension is a valid one (#62190) * Mobile - Image corrector - Check the path extension is a valid one * [Mobile] - Image corrector- Expand comment explaining the filtering for file: media paths * Integration Test helpers - Expand pasteIntoRichText to support passing files as a parameter * Mobile Editor Tests - Add new tests related to pasting HTML content with local image paths * Update snapshot * [Mobile] - Unsupported block - UI improvements (#62240) * Mobile - Unsupported block editor - Update editor style overrides * Mobile - Unsupported block - Update UI to show Tap to edit for unsupported blocks, simplifying the flow to open the Unsupported block editor * Fix unsupported block condition * Update snapshot * Fix condition for the help icon * Update Unsupported Block Editor condition and reverts the functionality to select the block first before opening the editor. * Release script: Update react-native-editor version to 1.120.0 * Release script: Update CHANGELOG for version 1.120.0 * Release script: Update podfile Co-authored-by: geriux <geriux@git.wordpress.org> Co-authored-by: SiobhyB <siobhyb@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…ordPress#62190) * Mobile - Image corrector - Check the path extension is a valid one * [Mobile] - Image corrector- Expand comment explaining the filtering for file: media paths * Integration Test helpers - Expand pasteIntoRichText to support passing files as a parameter * Mobile Editor Tests - Add new tests related to pasting HTML content with local image paths * Update snapshot
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
* Release script: Update react-native-editor version to 1.119.0 * Release script: Update CHANGELOG for version 1.119.0 * Release script: Update podfile * [Mobile] - Image corrector - Check the path extension is a valid one (WordPress#62190) * Mobile - Image corrector - Check the path extension is a valid one * [Mobile] - Image corrector- Expand comment explaining the filtering for file: media paths * Integration Test helpers - Expand pasteIntoRichText to support passing files as a parameter * Mobile Editor Tests - Add new tests related to pasting HTML content with local image paths * Update snapshot * [Mobile] - Unsupported block - UI improvements (WordPress#62240) * Mobile - Unsupported block editor - Update editor style overrides * Mobile - Unsupported block - Update UI to show Tap to edit for unsupported blocks, simplifying the flow to open the Unsupported block editor * Fix unsupported block condition * Update snapshot * Fix condition for the help icon * Release script: Update react-native-editor version to 1.119.1 * Release script: Update CHANGELOG for version 1.119.1 * Release script: Update podfile * Update Unsupported Block Editor condition and reverts the functionality to select the block first before opening the editor. * Update snapshot * Update package-lock.json --------- Co-authored-by: twstokes <twstokes@git.wordpress.org> Co-authored-by: geriux <geriux@git.wordpress.org> Co-authored-by: fluiddot <carlosgprim@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
* [Mobile] - Image corrector - Check the path extension is a valid one (WordPress#62190) * Mobile - Image corrector - Check the path extension is a valid one * [Mobile] - Image corrector- Expand comment explaining the filtering for file: media paths * Integration Test helpers - Expand pasteIntoRichText to support passing files as a parameter * Mobile Editor Tests - Add new tests related to pasting HTML content with local image paths * Update snapshot * [Mobile] - Unsupported block - UI improvements (WordPress#62240) * Mobile - Unsupported block editor - Update editor style overrides * Mobile - Unsupported block - Update UI to show Tap to edit for unsupported blocks, simplifying the flow to open the Unsupported block editor * Fix unsupported block condition * Update snapshot * Fix condition for the help icon * Update Unsupported Block Editor condition and reverts the functionality to select the block first before opening the editor. * Release script: Update react-native-editor version to 1.120.0 * Release script: Update CHANGELOG for version 1.120.0 * Release script: Update podfile Co-authored-by: geriux <geriux@git.wordpress.org> Co-authored-by: SiobhyB <siobhyb@git.wordpress.org>
geriux
added a commit
that referenced
this pull request
Jun 19, 2024
* [Mobile] - Image corrector - Check the path extension is a valid one (#62190) * Mobile - Image corrector - Check the path extension is a valid one * [Mobile] - Image corrector- Expand comment explaining the filtering for file: media paths * Integration Test helpers - Expand pasteIntoRichText to support passing files as a parameter * Mobile Editor Tests - Add new tests related to pasting HTML content with local image paths * Update snapshot * [Mobile] - Unsupported block - UI improvements (#62240) * Mobile - Unsupported block editor - Update editor style overrides * Mobile - Unsupported block - Update UI to show Tap to edit for unsupported blocks, simplifying the flow to open the Unsupported block editor * Fix unsupported block condition * Update snapshot * Fix condition for the help icon * Update Unsupported Block Editor condition and reverts the functionality to select the block first before opening the editor. * Release script: Update react-native-editor version to 1.120.0 * Release script: Update CHANGELOG for version 1.120.0 * Release script: Update podfile * [Mobile] - RichText - Fix `undefined` onDelete callback (#62486) * Native RichText - Fix undefined onDelete callback * Update changelog Co-authored-by: geriux <geriux@git.wordpress.org> Co-authored-by: twstokes <twstokes@git.wordpress.org> * Release script: Update react-native-editor version to 1.120.1 * Release script: Update podfile --------- Co-authored-by: geriux <geriux@git.wordpress.org> Co-authored-by: twstokes <twstokes@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
What?
This is a follow-up of #60676 that introduced a regression for the iOS app.
Why?
Recent changes in #60676 introduced a regression where iOS users cannot copy an image from their OS media library and paste it into the editor.
How?
By updating how we filter
filepaths when pasting HTML content.Testing Instructions
Note
Please use the following builds to test:
Pasting HTML content
HTML
Copy image from the iOS Media library
Testing Instructions for Keyboard
N/A
Screenshots or screencast
Copy image from the iOS Media library
ImageBugBefore.mov
ImageBugAfter.mov