UnitControl: preserve order of incoming units #62049
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
Size Change: +73 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
ramonjd
commented
May 28, 2024
| nonNullValueProp, | ||
| unitProp, | ||
| unitsProp | ||
| ); | ||
| // If allowedUnitValues is provided, we need to filter the list of units. | ||
| if ( allowedUnitValues?.length ) { |
There was a problem hiding this comment.
So this is a huge hack and just here to illustrate the proposal.
The goal is for this component to honor the order of units. For example, if I wanted to have % appear at the top of the unit list.
I'm just not sure whether to do it in the component or as part of useCustomUnits.
#31822 (comment) suggests that useCustomUnits might be the wrong place to do it.
There was a problem hiding this comment.
cc @ciampo for advice - non-urgent, when you get time 🙇🏻
…ds (eventually) to act in some way like `useCustomUnits` hook, but for now just filters the default units and preserves the order.
ramonjd
force-pushed
the
update/unit-control-preserve-order-of-allowed-units
branch
from
85c56d3
to
4b7ab27
Compare
|
Closing this as stale. I might come back to this idea one day. |
|
Sorry for the delay, I was on a parental leave and I'm still catching up with the notification queue. Happy to discuss the new approach if/when the time comes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Testing passing an allowedUnitValues prop to UnitControl, which intends (eventually) to act in some way like
useCustomUnitshook, but for now just filters the default units and preserves the order.See: #61928 (comment)
See also: #31822 (comment)
Why?
Consumers should be able to determine the order of the units in the control.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast