Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playwright E2E Utils: add fullscreenMode option to createNewPost #61766

Merged
merged 3 commits into from
May 20, 2024
Merged

Playwright E2E Utils: add fullscreenMode option to createNewPost #61766

merged 3 commits into from
May 20, 2024

Conversation

paolopiaggio
Copy link
Contributor

What?

Introduces fullscreenMode optional property to NewPostOptions and updates createNewPost function to set fullscreenMode preference based on the provided property if set, fallbacks to fullscreenMode: false otherwise.

Why?

Gives more flexibility allowing to configure preferences with fullscreenMode: true
@github-actions GitHub Actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @paolopiaggio.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: paolopiaggio.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label May 17, 2024
@github-actions GitHub Actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @paolopiaggio! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.
@paolopiaggio paolopiaggio marked this pull request as draft May 17, 2024 16:09
@paolopiaggio paolopiaggio changed the title Playwright E2E Utils: add fullscreenMode option to createNewPost function May 17, 2024
@paolopiaggio paolopiaggio marked this pull request as ready for review May 17, 2024 16:51
@Mamaduka Mamaduka added the [Type] Enhancement A suggestion for improvement. label May 18, 2024
kevin940726
kevin940726 approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@kevin940726 kevin940726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good addition. Thanks!
@kevin940726 kevin940726 merged commit f0995ad into WordPress:trunk May 20, 2024
62 checks passed
@github-actions GitHub Actions
Copy link

Congratulations on your first merged pull request, @paolopiaggio! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!
@github-actions github-actions bot added this to the Gutenberg 18.5 milestone May 20, 2024
@paolopiaggio paolopiaggio deleted the add/e2e-utils-admin-newpost-options branch May 20, 2024 08:08
@bph bph added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Package] E2E Tests /packages/e2e-tests and removed [Type] Enhancement A suggestion for improvement. labels Jun 3, 2024
patil-vipul pushed a commit to patil-vipul/gutenberg that referenced this pull request Jun 17, 2024
@paolopiaggio @patil-vipul
Playwright E2E Utils: add fullscreenMode option to createNewPost (Wor…
62761c7 
…dPress#61766)

Unlinked contributors: paolopiaggio.


* add fullscreenMode option to createNewPost function

* fix lint

* retrigger checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] E2E Tests /packages/e2e-tests [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
4 participants
@paolopiaggio @kevin940726 @bph @Mamaduka