Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Update "Link Text" label to "Text" on Social Icons block #60966 #61715

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Fix: Update "Link Text" label to "Text" on Social Icons block #60966 #61715

merged 1 commit into from
Jul 1, 2024

Conversation

hbhalodia
Copy link
Contributor

@hbhalodia hbhalodia commented May 16, 2024 •
edited
Loading

What?

Why?

  • This is need to make consistent and polish the blocks.

How?

  • This PR change the label and help text by removing the link word.

Testing Instructions

  1. Open any post/page.
  2. Add the social icons block and add the icons.
  3. For single icon, on the settings bar you can see the label is now changed to text, instead of link text.

Testing Instructions for Keyboard

  • NIL

Screenshots or screencast

Before After
Screenshot 2024-05-16 at 4 20 44 PM Screenshot 2024-05-16 at 4 14 20 PM
@hbhalodia hbhalodia requested a review from ajitbohra as a code owner May 16, 2024 10:52
@github-actions GitHub Actions
Copy link

github-actions bot commented May 16, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: hbhalodia <hbhalodia@git.wordpress.org>
Co-authored-by: akasunil <sunil25393@git.wordpress.org>
Co-authored-by: richtabor <richtabor@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.
@hbhalodia hbhalodia mentioned this pull request May 16, 2024
Closed
@juanfra juanfra added [Type] Copy Issues or PRs that need copy editing assistance [Block] Social Affects the Social Block - used to display Social Media accounts labels May 16, 2024
akasunil
akasunil approved these changes Jun 23, 2024
View reviewed changes
Copy link
Member

@akasunil akasunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
richtabor
richtabor approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@richtabor richtabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!
@richtabor richtabor enabled auto-merge (squash) July 1, 2024 12:24
@richtabor richtabor merged commit da23882 into WordPress:trunk Jul 1, 2024
59 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.8 milestone Jul 1, 2024
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Jul 18, 2024
@hbhalodia @richtabor @carstingaxion
Add consistent control label for social icons block (WordPress#61715)
b0d2be6 
Co-authored-by: hbhalodia <hbhalodia@git.wordpress.org>
Co-authored-by: akasunil <sunil25393@git.wordpress.org>
Co-authored-by: richtabor <richtabor@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Type] Copy Issues or PRs that need copy editing assistance
4 participants
@hbhalodia @richtabor @akasunil @juanfra