Make it clearer how to edit a site's palette #61364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -5.81 kB (-0.33%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
I could go either way on this one. My main reluctance is the word "Edit", which reads in active language but is actually in the conceptual space for "tips". I echo/understand the motivation for this: "10 colors" sounds like this is the final level. I don't recall if this was ever implemented in the ItemGroup component, but many older mockups showed a > chevron on the right side of Items that acted as drilldowns. That might work better here? |
It will look like the following, what do you think? I think it is also necessary to consider how it looks when the palette is empty.
|
|
@jasmussen Do you mean a chevron rather than "Edit"? |
|
Yes, I meant a chevron instead of "Edit". Similarly, the "Add palette" (perhaps "Add colors"?) feels less like help/tip text, and could be left-aligned black text. Not in any way a blocker, these are mainly thoughts on the component itself. |
|
I agree that this makes it easier to understand you can edit it but I'm not sure if we want to surface that as much considering the current experience is both easily overwriteable and, upon changing the palette, the changes aren't reflected in the presets. I opened an issue about this while testing: #61462 |
Left a comment there:
|
|
With #61213 implemented, it's quite a bit clearer that these are alternate palettes. And when you pick a palette, but then edit a color, that chosen palette is no longer "active", indicating that you have your own colors. A palette with my own colors, no longer referencing the preset:
|
|
@jasmussen here it is with a chevron. I think I prefer the "Edit" copy. what do you think?
|
richtabor
force-pushed
the
tweak/edit-palette
branch
from
974513a
to
6c81bcd
Compare
|
Flaky tests detected in 6c81bcd. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9181865622
|
|
I prefer the chevron :D but not strongly so. I'd say go with your instinct and we can revisit if need be. |
|
@jasmussen, I pushed the chevron—I like it too.
|
jasmussen
approved these changes
May 29, 2024
richtabor
force-pushed
the
tweak/edit-palette
branch
from
a8229f7
to
251d5e5
Compare
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
* "Edit" instead of color count * remove unused style * use chevron * Update style-variations.spec.js * lint Co-authored-by: richtabor <richtabor@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
* "Edit" instead of color count * remove unused style * use chevron * Update style-variations.spec.js * lint Co-authored-by: richtabor <richtabor@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
It needs to be clearer how to add or edit the site's palette. Currently we show how many colors you have, but I think showing ">" is a clearer call to action to navigate to the palette. Part of #61213 and #61215.
Testing Instructions
Screenshots or screencast