Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import in block editor’s readme example #61218

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

stokesman
Copy link
Contributor

What?

Fixes imports in example.

Why?

Docs should not contain mistakes.

How?

  • Removes WritingFlow import that was unused.
  • Adds BlockCanvas import that was missing.
`WritingFlow` import was unused and `BlockCanvas` import was missing.
@stokesman stokesman added [Type] Developer Documentation Documentation for developers [Package] Block editor /packages/block-editor labels Apr 29, 2024
Copy link

github-actions bot commented Apr 29, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: stokesman <presstoke@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@stokesman stokesman self-assigned this Apr 29, 2024
Copy link

Flaky tests detected in 54f24e1.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8884828783
📝 Reported issues:

Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! ✅

@stokesman stokesman merged commit 83737c1 into trunk Apr 30, 2024
67 checks passed
@stokesman stokesman deleted the fix/block-editor-readme-imports branch April 30, 2024 05:44
@github-actions github-actions bot added this to the Gutenberg 18.3 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Block editor /packages/block-editor [Type] Developer Documentation Documentation for developers
2 participants