Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added doc for components PageAttributesCheck, PageAttributesPanel, PageAttributesOrder, PageAttributesParent #60977

Merged

Conversation

akasunil
Copy link
Member

@akasunil akasunil commented Apr 23, 2024

What?

Part of: #60358

Added documentation in the readme for PageAttributesCheck, PageAttributesPanel, PageAttributesOrder, PageAttributesParent components and also on components itself.

@akasunil akasunil marked this pull request as ready for review April 25, 2024 08:33
Copy link

github-actions bot commented Apr 25, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: sunil25393 <sunil25393@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@@ -9,6 +9,14 @@ import { store as coreStore } from '@wordpress/core-data';
*/
import { store as editorStore } from '../../store';

/**
* Component for checking if the post type supports page attributes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like we should pick a wording and use it for all these components. So similar remark to this.

#61090 (comment)

@youknowriad youknowriad merged commit b7c633c into WordPress:trunk Apr 26, 2024
60 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.3 milestone Apr 26, 2024
@akasunil akasunil deleted the update/documentation-pageattributes branch April 26, 2024 13:26
huubl pushed a commit to huubl/gutenberg that referenced this pull request Apr 26, 2024
…geAttributesOrder, PageAttributesParent (WordPress#60977)

Co-authored-by: sunil25393 <sunil25393@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
@colorful-tones colorful-tones added the [Type] Developer Documentation Documentation for developers label May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
3 participants