Add test for Font Library and Theme Style Variations #60250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
requested review from
matiasbenedetto,
swissspidy,
mikachan and
creativecoder
getdave
added
[Type] Code Quality
|
Size Change: 0 B Total Size: 1.72 MB ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 77a4573. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8453351825
|
mikachan
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
I'm happy to approve this as a short-term solution until we're able to add unit tests for context.js.
Thanks for working on this, @getdave ✨
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
* Add test * Test an additional variation
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
* Add test * Test an additional variation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds test coverage for #59959.
Why?
Increase confidence for shipping this in WP 6.5 RC4. Also for code quality.
How?
Write a test that mirrors the instructions for replicating the original bug report in #59818
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast