-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Improve iOS Demo app build configuration #59791
build: Improve iOS Demo app build configuration #59791
Conversation
This script is not references anywhere and likely is now unnecessary given the current Xcode version is Xcore 14. wordpress-mobile/gutenberg-mobile@16c6a60
The `$(inherited)` value was added to address the following warnings. The additional `swift` path was added during subsequent app builds. ``` [!] The `GutenbergDemo [Debug]` target overrides the `LIBRARY_SEARCH_PATHS` build setting defined in `Pods/Target Support Files/Pods-GutenbergDemo/Pods-GutenbergDemo.debug.xcconfig'. This can lead to problems with the CocoaPods installation - Use the `$(inherited)` flag, or - Remove the build settings from the target. [!] The `GutenbergDemo [Release]` target overrides the `LIBRARY_SEARCH_PATHS` build setting defined in `Pods/Target Support Files/Pods-GutenbergDemo/Pods-GutenbergDemo.release.xcconfig'. This can lead to problems with the CocoaPods installation - Use the `$(inherited)` flag, or - Remove the build settings from the target. ```
Size Change: 0 B Total Size: 1.71 MB ℹ️ View Unchanged
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* build: Remove unused package script This script is not references anywhere and likely is now unnecessary given the current Xcode version is Xcore 14. wordpress-mobile/gutenberg-mobile@16c6a60 * build: Address iOS Demo app build warnings The `$(inherited)` value was added to address the following warnings. The additional `swift` path was added during subsequent app builds. ``` [!] The `GutenbergDemo [Debug]` target overrides the `LIBRARY_SEARCH_PATHS` build setting defined in `Pods/Target Support Files/Pods-GutenbergDemo/Pods-GutenbergDemo.debug.xcconfig'. This can lead to problems with the CocoaPods installation - Use the `$(inherited)` flag, or - Remove the build settings from the target. [!] The `GutenbergDemo [Release]` target overrides the `LIBRARY_SEARCH_PATHS` build setting defined in `Pods/Target Support Files/Pods-GutenbergDemo/Pods-GutenbergDemo.release.xcconfig'. This can lead to problems with the CocoaPods installation - Use the `$(inherited)` flag, or - Remove the build settings from the target. ```
What?
Address warnings and remove unused scripts.
Why?
Reduce noise found in build scripts and processes.
How?
build: Remove unused package script
This script is not references anywhere and likely is now unnecessary
given the current Xcode version is Xcore 14.
wordpress-mobile/gutenberg-mobile@16c6a60
build: Address iOS Demo app build warnings
The
$(inherited)
value was added to address the following warnings.The additional
swift
path was added during subsequent app builds.Testing Instructions
Verify
npm run native ios -- -- --simulator="iPhone 15"
succeeds.Testing Instructions for Keyboard
N/A, no user-facing changes.
Screenshots or screencast
N/A, no user-facing changes.