[RNMobile] Fix issue in synced patterns related to missing getRichTextValues private API
#59632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This module is used in the footnotes logic, which is triggered on changes in the content of a synced pattern.
fluiddot
added
[Type] Bug
|
Size Change: +57 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
fluiddot
commented
Mar 6, 2024
| @@ -42,6 +44,7 @@ const getMockedReusableBlock = ( id ) => ( { | |||
| id, | |||
| title: { raw: `Reusable block - ${ id }` }, | |||
| type: 'wp_block', | |||
| meta: { footnotes: '' }, | |||
There was a problem hiding this comment.
As far as I checked, the meta property is always included in the content response of synced patterns.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
geriux
approved these changes
Mar 6, 2024
fluiddot
added a commit
that referenced
this pull request
Mar 8, 2024
…xtValues` private API (#59632) * Export `getRichTextValues` private API This module is used in the footnotes logic, which is triggered on changes in the content of a synced pattern. * Add integration test to cover issue's case
4 tasks
fluiddot
added a commit
that referenced
this pull request
Mar 11, 2024
* Release script: Update react-native-editor version to 1.114.0 * Release script: Update CHANGELOG for version 1.114.0 * Release script: Update podfile * fix: Restore Xcode 15 patch See: #59461 * Release script: Update react-native-editor version to 1.114.1 * Release script: Update CHANGELOG for version 1.114.1 * Release script: Update podfile * [RNMobile] Fix issue in synced patterns related to missing `getRichTextValues` private API (#59632) * Export `getRichTextValues` private API This module is used in the footnotes logic, which is triggered on changes in the content of a synced pattern. * Add integration test to cover issue's case --------- Co-authored-by: Siobhan <siobhan@automattic.com>
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
* Release script: Update react-native-editor version to 1.114.0 * Release script: Update CHANGELOG for version 1.114.0 * Release script: Update podfile * fix: Restore Xcode 15 patch See: WordPress#59461 * Release script: Update react-native-editor version to 1.114.1 * Release script: Update CHANGELOG for version 1.114.1 * Release script: Update podfile * [RNMobile] Fix issue in synced patterns related to missing `getRichTextValues` private API (WordPress#59632) * Export `getRichTextValues` private API This module is used in the footnotes logic, which is triggered on changes in the content of a synced pattern. * Add integration test to cover issue's case --------- Co-authored-by: Siobhan <siobhan@automattic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes an issue in Synced patterns related to updates in the content. The solution applied is based on the investigations shared in this comment.
Why?
It addresses an issue that makes the editor crash.
Fixes wordpress-mobile/gutenberg-mobile#6703.
Fixes wordpress-mobile/WordPress-iOS#22776.
Fixes wordpress-mobile/WordPress-Android#20369.
How?
Export
getRichTextValuesprivate API in the native version.Testing Instructions
Follow the reproduction steps outlined in wordpress-mobile/gutenberg-mobile#6703. The expectation is that the editor doesn't crash when inserting/rendering the synced pattern.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A