Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Configure GitHub Action ruby version #59106

Conversation

dcalhoun
Copy link
Member

What?

Configure GitHub Action ruby version.

Why?

Avoid unexpected outcome differences between CI and local development machines.

How?

Update the GitHub Action configuration to locate the .ruby-version file.

Testing Instructions

N/A, no user-facing changes.

Testing Instructions for Keyboard

N/A, no user-facing changes.

Screenshots or screencast

N/A, no user-facing changes.

@dcalhoun dcalhoun added [Type] Build Tooling Issues or PRs related to build tooling Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Feb 15, 2024
Previously, the CI would load the default ruby version, which caused
unexpected outcomes.
@dcalhoun dcalhoun force-pushed the build/configure-github-actions-ruby-version branch from f6d3cac to 1d6c81c Compare February 15, 2024 20:11
@dcalhoun dcalhoun marked this pull request as ready for review February 15, 2024 20:14
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: dcalhoun <dpcalhoun@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@dcalhoun dcalhoun merged commit 63aa04a into build/upgrade-to-react-native-0.73 Feb 15, 2024
47 of 50 checks passed
@dcalhoun dcalhoun deleted the build/configure-github-actions-ruby-version branch February 15, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Build Tooling Issues or PRs related to build tooling
1 participant