Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It works like that also. #58880

Closed
wants to merge 1 commit into from

Conversation

hemanttejwani2610
Copy link

So need of capital E 'Edit'.

What?

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

So need of capital E 'Edit'.
Copy link

github-actions bot commented Feb 9, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @hemanttejwani2610.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: hemanttejwani2610.


To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Feb 9, 2024
Copy link

github-actions bot commented Feb 9, 2024

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @hemanttejwani2610! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@talldan talldan added [Type] Bug An existing feature does not function as intended [Package] Create Block /packages/create-block [Type] Code Quality Issues or PRs that relate to code quality and removed [Type] Bug An existing feature does not function as intended labels Feb 12, 2024
@talldan
Copy link
Contributor

talldan commented Feb 12, 2024

Thanks for suggesting the change.

It doesn't seem necessary, so I don't think this needs to be changed, most core blocks also rename the default import to a lower case edit:

I'll close the PR.

@talldan talldan closed this Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Create Block /packages/create-block [Type] Code Quality Issues or PRs that relate to code quality
2 participants