[RNMobile] Use ActivityIndicator to display media upload progress #58759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekblank
added
[Type] Enhancement
|
Size Change: +41 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 56feadf. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7911704345
|
2 tasks
…cator-media-upload-progress
…cator-media-upload-progress
|
Closing as paused for further consideration. Can re-open when needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses:
What?
Updates the mobile MediaProgressUpload component to use a spinner in place of a progress bar. Also includes a checkmark success state.
Why?
As part of ongoing efforts to improve the media upload experience, we have received feedback that Image upload process could be improved by modifying an "in progress" state when uploading Images.
This PR focuses on UI display only, and intentionally does not update any of the media progress upload logic in order to reduce regressions.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Todo
Currently this change applies to all media blocks: