Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed extra parenthesis from document #58662

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

krupal-panchal
Copy link
Contributor

@krupal-panchal krupal-panchal commented Feb 5, 2024

What?

Removing the extra parenthesis ")" from the document.

Why?

https://developer.wordpress.org/block-editor/getting-started/fundamentals/javascript-in-the-block-editor/#javascript-without-a-build-process
In this section, one code is given to check the blocks in admin. But the code contains extra parenthesis and it gives an error.

How?

Removed extra parenthesis. Corrected the code.

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Feb 5, 2024
Copy link

github-actions bot commented Feb 5, 2024

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @krupal-panchal! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@t-hamano t-hamano added the [Type] Developer Documentation Documentation for developers label Feb 5, 2024
@t-hamano t-hamano self-requested a review February 5, 2024 12:12
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks 🚀

@WordPress WordPress deleted a comment from github-actions bot Feb 5, 2024
@desrosj desrosj added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Feb 5, 2024
Copy link

github-actions bot commented Feb 5, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

If you're a Core Committer, use this list when committing to wordpress-develop in SVN:

Props: krupalpanchal, wildworks.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: krupal-panchal <krupalpanchal@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Feb 5, 2024
Copy link
Contributor

@desrosj desrosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing a review comment.

@t-hamano t-hamano merged commit 9353540 into WordPress:trunk Feb 5, 2024
62 of 67 checks passed
@github-actions github-actions bot added this to the Gutenberg 17.7 milestone Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers
3 participants