build: Upgrade to React Native 0.73 (iOS) #58522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcalhoun
added
[Type] Build Tooling
dcalhoun
force-pushed
the
build/upgrade-to-react-native-0.73-iOS
branch
from
3b892eb
to
1451714
Compare
|
Size Change: 0 B Total Size: 1.7 MB ℹ️ View Unchanged
|
dcalhoun
commented
Jan 31, 2024
Comment on lines
-65
to
-69
| # The following workaround is needed to avoid the error `typedef redefinition with different types ('uint8_t' (aka 'unsigned char') vs 'enum clockid_t')`. | ||
| # This solution is referenced in https://github.com/facebook/react-native/issues/39568#issuecomment-1762890606. | ||
| # It will be needed until RCT-Folly version is bumped in React Native to version v2022.08.29.00 or above. | ||
| # Referece: https://github.com/facebook/folly/commit/4a2410fae65afb85e1fec6d922005054b05de59f | ||
| __apply_Xcode_12_5_M1_post_install_workaround(installer) |
There was a problem hiding this comment.
This threw an error during pod install and appears to no longer be necessary.
|
|
||
| # Uncomment the next line to define a global platform for your project | ||
| app_ios_deployment_target = Gem::Version.new('13.0') | ||
| app_ios_deployment_target = Gem::Version.new('13.4') |
There was a problem hiding this comment.
Noting the deployment target bump here done to address an error during pod install. We should consider if this bump is a problem here in the Demo editor or in the host app.
| # It will be needed until RCT-Folly version is bumped in React Native to version v2022.08.29.00 or above. | ||
| # Referece: https://github.com/facebook/folly/commit/4a2410fae65afb85e1fec6d922005054b05de59f | ||
| __apply_Xcode_12_5_M1_post_install_workaround(installer) | ||
|
|
||
| # Let Pods targets inherit deployment target from the app | ||
| # This solution is suggested here: https://github.com/CocoaPods/CocoaPods/issues/4859 |
There was a problem hiding this comment.
We should explore if some of these workaround in this file can now be removed.
| @@ -63,7 +63,7 @@ | |||
| "react-native-get-random-values": "1.4.0", | |||
| "react-native-linear-gradient": "2.7.3", | |||
| "react-native-modal": "13.0.1", | |||
| "react-native-reanimated": "2.17.0", | |||
| "react-native-reanimated": "3.6.2", | |||
There was a problem hiding this comment.
Much like Android, upgrading to Reanimated 3 is required to address errors from incompatible builds/dependencies.
This was done to address the following error when installing Pods:
```
[!] CocoaPods could not find compatible versions for pod "React-FabricImage":
In Podfile:
React-FabricImage (from `../../../node_modules/react-native/ReactCommon`)
Specs satisfying the `React-FabricImage (from `../../../node_modules/react-native/ReactCommon`)` dependency were found, but they required a higher minimum deployment target.
```
Required to address the following error. https://stackoverflow.com/a/77257722/378228 ``` No template named 'optional' in namespace 'std'; did you mean 'folly::Optional'? ```
Align with the latest React Native template to avoid future conflicts.
dcalhoun
force-pushed
the
build/upgrade-to-react-native-0.73-iOS
branch
from
5e43582
to
0f4f363
Compare
dcalhoun
merged commit 532436d
into
build/upgrade-to-react-native-0.73
22 of 56 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Upgrade the iOS code for React Native 0.73.
Why?
See #58475.
How?
Testing Instructions
Verify the Demo editor builds and launches without issue.
Testing Instructions for Keyboard
N/A, no user-facing changes.
Screenshots or screencast
N/A, no user-facing changes.