[RNMobile] Upgrade target sdk version to Android API 34 #57918
Closed
+1,399
−1,684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The modifications were automatically made when installing pods.
The workaround solves the issue related to redefining `clockid_t` in the pod `RCT-Folly`.
fluiddot
added
[Type] Build Tooling
|
Flaky tests detected in ea7cd51. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7555941032
|
Base automatically changed from
rnmobile/upgrade/react-native-0.71.15
to
trunk
January 30, 2024 10:26
|
FYI I'm continuing this effort at #61727 thank you for the initial work that has made finishing the update easier 🚀 |
|
Closing in favor of #61727. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Upgrade
react-native-aztec,react-native-bridge, andreact-native-editorprojects to Android 14 (API 34). As well as the different React Native dependencies:react-native-libraries-publisherreact-native-sliderreact-native-videoWhy?
This is required to enable upgrading the Android SDK in the apps.
How?
targetSdkVersion.AztecEditor-Androidversion to the one that upgraded to Android 14 (react-native-libraries-publisherreact-native-sliderreact-native-videoTesting Instructions
This change doesn't affect a specific area, hence to test it we should basically smoke test the editor and check that works as expected.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A