fix: Prevent text from being cut off in mobile OfflineStatus component #57783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekblank
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.7 MB ℹ️ View Unchanged
|
|
@dcalhoun As this component is yet to be released, I do not believe a CHANGELOG update is required, as we'd be covered by the following: WDYT? |
dcalhoun
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves an Android issue where text was being cut off in the OfflineStatus component when bold text was being used.
Why?
This appears to be a legitimate bug in React Native:
When a bold typeface style is used, the last node of the text appears to be removed.
When there are two or more words in one
<Text>element, the last word is removed:When there is one word in a
<Text>element, the last letter is removed:When there are two or more words in one
<Text>element and a space is added, the space is removed:How?
This PR adds a space to the end of the element in OfflineStatus to workaround the issue. This space does not appear to impact the UI.
Note: the space appears outside of the i18n string to avoid invoking the i18n-no-flanking-whitespace linter error.
This PR also removes an extra
<View style={ containerStyle }></View>that appears to be redundant from its parent.Testing Instructions
Testing note: I was not able to consistently reproduce the original issue across various Android devices. I was not able to replicate the issue on a Samsung Galaxy FE20 or Google Pixel 6 Pro, but could consistently replicate it on a Pixel One.